Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export InputContributionError #370

Closed
wants to merge 1 commit into from
Closed

Export InputContributionError #370

wants to merge 1 commit into from

Conversation

DanGould
Copy link
Contributor

@DanGould DanGould commented Oct 16, 2024 •
edited
Loading

Since it's a public error downstream implementations may need to switch on it or define types over it

I need this specifically for bindings

@DanGould
Export InputContributionError
b11f94d 
Since it's a public error downstream implementations may need
to switch on it or define types over it
@spacebear21
Copy link
Collaborator

Sorry I missed this earlier, but I noticed this too and fixed it in 0af90e6#diff-5fba6fc39c59b07e5980d87da92537138068364d192a2b63eee5e57af01a07bb which is now merged. Closing this.

@DanGould
Copy link
Contributor Author

Good on you. I foresee a bunch of these publicity commits coming down the pipe in the next week or so to accommodate ffi and get our api closer to stable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacebear21 spacebear21 Awaiting requested review from spacebear21

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanGould @spacebear21